commit 23cc46a01af9cfdd2ff0949d1c3d4a48830ee847 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 20:43:37 2016 -0300 event: fix comparison if event is today Since the end times are open-ended, we have to consider the very second before the actual end time. https://bugzilla.gnome.org/show_bug.cgi?id=772104 src/gcal-event.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) commit 159da57e4698c19a82caf3eb812a78fb21e975c2 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 20:35:32 2016 -0300 quick-add-popover: always set seconds to 0 https://bugzilla.gnome.org/show_bug.cgi?id=772104 src/gcal-quick-add-popover.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e8dbe48baacf0e91efc342b2bb9785e0feefdc85 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 20:15:14 2016 -0300 quick-add-popover: focus "Create" button after selecting an agenda So that the keyboard flow is smooth and clean. https://bugzilla.gnome.org/show_bug.cgi?id=770714 src/gcal-quick-add-popover.c | 3 +++ 1 file changed, 3 insertions(+) commit 152f6ff8b7e33f8eda15ad9a4084a9b05953d117 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 19:56:01 2016 -0300 month-view: use G_DECLARE_FINAL_TYPE Instead of using the old GLib boilerplate code, use the new utilities and simplify the code a little bit. This also allows us to remove the private field of month view. src/gcal-month-view.c | 613 ++++++++++++++++++++++++-------------------------- src/gcal-month-view.h | 26 +-- 2 files changed, 294 insertions(+), 345 deletions(-) commit a2edfd48b6c8b14e0b69f38a39b81ce0e2b6b3cc Author: Georges Basile Stavracas Neto Date: Sat Oct 1 19:54:54 2016 -0300 subscriber-view: add an autoptr cleanup function So that we can use G_DECLARE_{FINAL,DERIVABLE}_TYPE() utility macros. src/gcal-subscriber-view.h | 2 ++ 1 file changed, 2 insertions(+) commit 0843f9e93e847a9979d32c6c6e7f665685e1bbab Author: djb Date: Fri Sep 30 19:35:30 2016 +0100 application: stop force disabling dark theme https://bugzilla.gnome.org/show_bug.cgi?id=758057 src/gcal-application.c | 2 -- 1 file changed, 2 deletions(-) commit 52a9864cba061fe2c6ddce1991df89c9db90ec20 Author: Victor Toso Date: Sat Oct 1 00:26:23 2016 +0200 date-chooser: Fix GDateTime leak By using finalize and dispose methods and calling the proper free method. 8,806 (64 direct, 8,742 indirect) bytes in 2 blocks are definitely lost in loss record 18,051 of 18,131 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x9A0C90E: g_malloc (gmem.c:94) by 0x9A26A55: g_slice_alloc (gslice.c:1025) by 0x9A26A95: g_slice_alloc0 (gslice.c:1051) by 0x99E8DC4: g_date_time_alloc (gdatetime.c:428) by 0x99E95C1: g_date_time_new (gdatetime.c:957) by 0x99E97B2: g_date_time_new_local (gdatetime.c:1012) by 0x4251F4: multi_choice_changed (gcal-date-chooser.c:419) by 0x9567F16: g_cclosure_marshal_VOID__PARAM (gmarshal.c:1832) by 0x95638B9: g_closure_invoke (gclosure.c:804) by 0x957FD25: signal_emit_unlocked_R (gsignal.c:3635) by 0x957F05C: g_signal_emit_valist (gsignal.c:3391) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-date-chooser.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) commit f713a90ea3fca2d482a265f08841f7e40f8f7c99 Author: Victor Toso Date: Sat Oct 1 00:16:20 2016 +0200 time-selector: Fix GDateTime leak By using finalize and dispose methods and calling the proper free methods calls. 8,806 (64 direct, 8,742 indirect) bytes in 2 blocks are definitely lost in loss record 18,367 of 18,534 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x9A0C90E: g_malloc (gmem.c:94) by 0x9A26A55: g_slice_alloc (gslice.c:1025) by 0x9A26A95: g_slice_alloc0 (gslice.c:1051) by 0x99E8DC4: g_date_time_alloc (gdatetime.c:428) by 0x99E8FA3: g_date_time_from_instant (gdatetime.c:524) by 0x99E933F: g_date_time_new_from_timeval (gdatetime.c:647) by 0x99E93A5: g_date_time_new_now (gdatetime.c:705) by 0x99E93C4: g_date_time_new_now_local (gdatetime.c:728) by 0x445BED: gcal_time_selector_init (gcal-time-selector.c:249) by 0x9584B32: g_type_create_instance (gtype.c:1866) by 0x956BED0: g_object_new_internal (gobject.c:1783) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-time-selector.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) commit 03d1e549f2b201451b89b9ebc71a7107d1001407 Author: Victor Toso Date: Sat Oct 1 00:00:03 2016 +0200 event: Fix leak of GdkRGBA 23,776 bytes in 743 blocks are definitely lost in loss record 19,053 of 19,159 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x9A0C90E: g_malloc (gmem.c:94) by 0x9A26A55: g_slice_alloc (gslice.c:1025) by 0x9A26AD7: g_slice_copy (gslice.c:1076) by 0x6A97912: gdk_rgba_copy (gdkrgba.c:76) by 0x42B35E: gcal_event_set_color (gcal-event.c:750) by 0x42BF3E: gcal_event_set_source (gcal-event.c:1204) by 0x42AE20: gcal_event_set_property (gcal-event.c:481) by 0x956B39B: object_set_property (gobject.c:1423) by 0x956BFDF: g_object_new_internal (gobject.c:1817) by 0x956CB24: g_object_new_valist (gobject.c:2042) by 0x878945D: g_initable_new_valist (ginitable.c:224) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-event.c | 1 + 1 file changed, 1 insertion(+) commit ea70173cd3e761cdcd53327a3848a2b6b9f2fcf4 Author: Victor Toso Date: Fri Sep 30 23:56:57 2016 +0200 event: Fix leak of uid (string) 28,337 bytes in 415 blocks are definitely lost in loss record 18,432 of 18,507 at 0x4C2FC47: realloc (vg_replace_malloc.c:785) by 0xA88021D: vasprintf (in /usr/lib64/libc-2.24.so) by 0x9A593FC: g_vasprintf (gprintf.c:316) by 0x9A292F7: g_strdup_vprintf (gstrfuncs.c:514) by 0x9A2939C: g_strdup_printf (gstrfuncs.c:540) by 0x42A10B: gcal_event_update_uid_internal (gcal-event.c:192) by 0x42BF52: gcal_event_set_source (gcal-event.c:1217) by 0x42ADCA: gcal_event_set_property (gcal-event.c:480) by 0x956B39B: object_set_property (gobject.c:1423) by 0x956BFDF: g_object_new_internal (gobject.c:1817) by 0x956CB24: g_object_new_valist (gobject.c:2042) by 0x878945D: g_initable_new_valist (ginitable.c:224) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-event.c | 1 + 1 file changed, 1 insertion(+) commit 86d91b75988bf47d70dac98f86a3230685e8e76c Author: Victor Toso Date: Fri Sep 30 23:53:36 2016 +0200 event: Fix leak of EcalComponentId 29,717 (8,128 direct, 21,589 indirect) bytes in 508 blocks are definitely lost in loss record 18,380 of 18,445 at 0x4C2FA50: calloc (vg_replace_malloc.c:711) by 0x9A0C981: g_malloc0 (gmem.c:124) by 0x9A0CC64: g_malloc0_n (gmem.c:355) by 0x5BE3948: e_cal_component_get_id (e-cal-component.c:1477) by 0x42A06D: gcal_event_update_uid_internal (gcal-event.c:178) by 0x42A64D: gcal_event_set_component_internal (gcal-event.c:310) by 0x42AD0F: gcal_event_set_property (gcal-event.c:459) by 0x956B39B: object_set_property (gobject.c:1423) by 0x956BFDF: g_object_new_internal (gobject.c:1817) by 0x956CB24: g_object_new_valist (gobject.c:2042) by 0x878945D: g_initable_new_valist (ginitable.c:224) by 0x878933A: g_initable_new (ginitable.c:146) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-event.c | 1 + 1 file changed, 1 insertion(+) commit aee120b898a84f9a78d193b0e9ab0a492167cc59 Author: Victor Toso Date: Fri Sep 30 23:47:46 2016 +0200 event: Fix leak of alarm (GHashTable) 105,858 (42,064 direct, 63,794 indirect) bytes in 478 blocks are definitely lost in loss record 19,065 of 19,103 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x9A0C90E: g_malloc (gmem.c:94) by 0x9A26A55: g_slice_alloc (gslice.c:1025) by 0x99F0510: g_hash_table_new_full (ghash.c:711) by 0x42B10C: gcal_event_init (gcal-event.c:657) by 0x9584B32: g_type_create_instance (gtype.c:1866) by 0x956BED0: g_object_new_internal (gobject.c:1783) by 0x956CB24: g_object_new_valist (gobject.c:2042) by 0x878945D: g_initable_new_valist (ginitable.c:224) by 0x878933A: g_initable_new (ginitable.c:146) by 0x42B181: gcal_event_new (gcal-event.c:690) by 0x4549CA: gcal_year_view_component_added (gcal-year-view.c:1632) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-event.c | 1 + 1 file changed, 1 insertion(+) commit 705d9809f9b02c88731b71ae82b2eaa0cd936998 Author: Victor Toso Date: Fri Sep 30 23:42:31 2016 +0200 date-chooser: Fix leak of GDateTime 264,180 (1,920 direct, 262,260 indirect) bytes in 60 blocks are definitely lost in loss record 18,487 of 18,509 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x9A0C90E: g_malloc (gmem.c:94) by 0x9A26A55: g_slice_alloc (gslice.c:1025) by 0x9A26A95: g_slice_alloc0 (gslice.c:1051) by 0x99E8DC4: g_date_time_alloc (gdatetime.c:428) by 0x99E95C1: g_date_time_new (gdatetime.c:957) by 0x99E97B2: g_date_time_new_local (gdatetime.c:1012) by 0x42481C: calendar_compute_days (gcal-date-chooser.c:150) by 0x425F3B: gcal_date_chooser_set_date (gcal-date-chooser.c:743) by 0x4251CD: multi_choice_changed (gcal-date-chooser.c:420) by 0x9567F16: g_cclosure_marshal_VOID__PARAM (gmarshal.c:1832) by 0x95638B9: g_closure_invoke (gclosure.c:804) https://bugzilla.gnome.org/show_bug.cgi?id=772272 src/gcal-date-chooser-day.c | 1 + 1 file changed, 1 insertion(+) commit 62aa66b8da971a1bb067c56ab3b0c339188631f3 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 19:16:18 2016 -0300 year-view: implement scrolling to change year Following the previous work on month view, this commit implements scrolling capabilities to Year view. We do this not only with the :scroll-event, but also using the :edge-overshot signal of GtkScrolledWindow. data/ui/year-view.ui | 4 +++- src/gcal-year-view.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) commit eb7ad4959b3f154a56b7bbebeda80d2d572023c2 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 18:55:23 2016 -0300 month-view: allow changing months with scrolling It is very natural and intuitive to try and change the current date by scrolling. The current implementation of the Month view, however, blatantly ignores scroll events. Fix that by hearing to the scrolling events and changing the month when the scroll is enough. src/gcal-month-view.c | 33 +++++++++++++++++++++++++++++++-- src/gcal-utils.c | 36 ++++++++++++++++++++++++++++++++++++ src/gcal-utils.h | 3 +++ 3 files changed, 70 insertions(+), 2 deletions(-) commit 55b21874a77602eadf0dc88ddb7ce83afcf05a44 Author: Georges Basile Stavracas Neto Date: Sat Oct 1 18:32:24 2016 -0300 event-widget: propagate scrolling event When the event widget's GdkWindow receives an event scroll, the event is lost because it doesn't handle it. It should, however, propagate the scroll event so that the container is able to properly parse it. Fix that by making GcalEventWidget listen and propagate scrolled events. src/gcal-event-widget.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 81b178acff81c0d6854a26665a644e4bbb1ce1d5 Author: Georges Basile Stavracas Neto Date: Wed Sep 28 21:04:51 2016 -0300 search-view: fix segfault src/gcal-search-view.c | 3 --- 1 file changed, 3 deletions(-) commit be3833b977a6ad59731423debd1c6af86a2894f2 Author: Georges Basile Stavracas Neto Date: Wed Sep 28 01:11:14 2016 -0300 quick-add-popover: only increase day on single day events src/gcal-quick-add-popover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 653fb86d16c408ae9a8942eb3064dc79384b132d Author: Georges Basile Stavracas Neto Date: Wed Sep 28 01:02:45 2016 -0300 quick-add-popover: fix single all-day events src/gcal-quick-add-popover.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit a8f4346e1cf909d0f1ad570c872ade05164d0f06 Author: Georges Basile Stavracas Neto Date: Wed Sep 28 00:34:23 2016 -0300 edit-dialog: setup the correct label when selecting a calendar Since now we manually manage the headerbar title and subtitle, setting them via GtkHeaderBar API won't have any effect. Fix that by directly setting the subtitle label. https://bugzilla.gnome.org/show_bug.cgi?id=771565 src/gcal-edit-dialog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 1e1452810e0a0a4263c8b742355586ade472da4f Author: Georges Basile Stavracas Neto Date: Wed Sep 28 00:28:55 2016 -0300 quick-add-popover: only today events are timed Everything else is all day. https://bugzilla.gnome.org/show_bug.cgi?id=770713 src/gcal-quick-add-popover.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit f1069c96d6e63f5f3f643080bb92bf29c20de4f6 Author: Georges Basile Stavracas Neto Date: Wed Sep 28 00:07:28 2016 -0300 event: implement GInitable Since the event creation can fail, lets make it a GInitable so that we can fail during initialization. https://bugzilla.gnome.org/show_bug.cgi?id=763166 src/gcal-event.c | 95 ++++++++++++++++++++++++++++++++++++++++---- src/gcal-event.h | 12 +++++- src/gcal-manager.c | 14 ++++++- src/gcal-quick-add-popover.c | 2 +- src/gcal-search-view.c | 17 ++++---- src/gcal-subscriber-view.c | 24 ++++++++++- src/gcal-window.c | 2 +- src/gcal-year-view.c | 13 +++++- 8 files changed, 155 insertions(+), 24 deletions(-) commit e79bdfb9331285d933ccc38f8063fe7eabd6bef5 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 23:16:20 2016 -0300 search-view: fix time label We want to show "All day" when the event is all day, not when it ~isn't~ all day. https://bugzilla.gnome.org/show_bug.cgi?id=771677 src/gcal-search-view.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4582ade21df6711e30c1d5ae4bee38243970d79d Author: Georges Basile Stavracas Neto Date: Tue Sep 27 22:48:27 2016 -0300 edit-dialog: sync time and date widgets' sizing So the time widgets don't grow over the date widgets and break the vertical layout of the edit dialog. https://bugzilla.gnome.org/show_bug.cgi?id=771440 data/ui/edit-dialog.ui | 2 -- 1 file changed, 2 deletions(-) commit 81873994da3a2977cf9228a3f2f357a14c04a1a1 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 22:41:17 2016 -0300 views: protect against invalid drop If the user tries to drop a e.g. file, GNOME Calendar crashes immediately. While the desired behavior would be checking if that's an ics file, lets just not crash for now. https://bugzilla.gnome.org/show_bug.cgi?id=771680 src/gcal-month-view.c | 4 ++++ src/gcal-year-view.c | 3 +++ 2 files changed, 7 insertions(+) commit 10391ae6a98992f3a8de2316f870c85809690c17 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 22:35:48 2016 -0300 manager: setup default calendar on event creation When an event is successfully created, make that the default source. https://bugzilla.gnome.org/show_bug.cgi?id=771570 src/gcal-manager.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit df13ac2a5924dec8dfd23a68c6b850333a839ed9 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 22:30:11 2016 -0300 quick-add-popover: track default calendar Update the selected calendar when the default one changes. https://bugzilla.gnome.org/show_bug.cgi?id=771570 src/gcal-quick-add-popover.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) commit dfdcb7c29c0a86a3a666b328b85416d8f520fdde Author: Georges Basile Stavracas Neto Date: Tue Sep 27 22:28:59 2016 -0300 manager: add ::default-calendar property This property acts as a proxy to ESourceRegistry::default-calendar and will be used by future patches to track when the default calendar changes. https://bugzilla.gnome.org/show_bug.cgi?id=771570 src/gcal-manager.c | 48 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 5 deletions(-) commit 97f8979c535665dda1f7d7e66572d52ea2220888 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 21:48:07 2016 -0300 month-view: hide overflow popover on drag and drop When the user starts a drag operation from the overflow popover, it should hide itself, otherwise it can block dropping the event below it. Currently, this is not what happens. Fix that by making the overflow popover a drag and drop target, and hide it when it detects drag movement. https://bugzilla.gnome.org/show_bug.cgi?id=771663 src/gcal-month-view.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) commit a76d40d2900085ac97baf0f100c3bd535bcc4f84 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 21:30:43 2016 -0300 quick-add-popover: only show writable calendars There is no reason to display read-only calendars, since the user can't add any events on it. Fix that by only showing writable calendars. https://bugzilla.gnome.org/show_bug.cgi?id=768324 src/gcal-quick-add-popover.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) commit 9da6896105108b5948ca62b0604dfec20f9133d2 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 21:29:49 2016 -0300 manager: remove unused ::source-activated signal We're not using it anymore, no need to keep it here. https://bugzilla.gnome.org/show_bug.cgi?id=768324 src/gcal-manager.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 3ef45ccf9fd95a6074a771969051160981c0e011 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 21:20:45 2016 -0300 quick-add-popover: focus the summary entry when shown So the user can start typing right away. data/ui/quick-add-popover.ui | 1 + 1 file changed, 1 insertion(+) commit 96626352d389c941e5d5ae4b5f0c775fa6ad3a70 Author: Georges Basile Stavracas Neto Date: Tue Sep 27 21:08:09 2016 -0300 month-view: calculate popover events on a per-event basis Since we need to special-case the datetimes to deal with UTC all day events, using a general local GTimeZone would cause the cloned all-day events to show wrongly inside the popover. Fix that by calculating each event's start and end dates according to the all day events. https://bugzilla.gnome.org/show_bug.cgi?id=771655 src/gcal-month-view.c | 49 +++++++++++++++++++++++++++---------------------- 1 file changed, 27 insertions(+), 22 deletions(-) commit 090d7d9c427850371f681b49d498b947ed3a0afe Author: fosero Date: Thu Sep 15 13:32:10 2016 +0200 edit-dialog.ui: Allow notes scroll while non-editable Allow scrolling of the GtkTextview in non-editable state. Also show the cursor when editable. https://bugzilla.gnome.org/show_bug.cgi?id=771485 data/ui/edit-dialog.ui | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) commit 8d4d7f40ac2f6d493f153de1e76484d66e9dffe6 Author: gogo Date: Thu Sep 22 21:01:51 2016 +0000 Added Croatian translation po/LINGUAS | 1 + po/hr.po | 563 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 564 insertions(+) commit 0d4f50cb3d94134f4e9d26822de99e68e4903a7b Author: Khaled Hosny Date: Wed Sep 21 08:47:52 2016 +0200 Update Arabic translation po/ar.po | 211 +++++++++++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 157 insertions(+), 54 deletions(-) commit 54470d21e9c91b26cba5c850d733732fb618c293 Author: Georges Basile Stavracas Neto Date: Mon Sep 19 16:28:45 2016 -0300 Bump 3.22.0 release NEWS | 8 ++++++++ configure.ac | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)