From 32c1aac9bcf8bb5768d4a16c2048fd5a5e30f3f1 Mon Sep 17 00:00:00 2001 From: Sveinung Kvilhaugsvik Date: Tue, 23 Feb 2021 09:17:02 +0100 Subject: [PATCH 2/2] universal_never_there(): find unused extra flags. Detect when an extra type flag never is in use. This allows Ruledit and its other users to detect unused extra flags being required. See osdn #41637 --- common/requirements.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/requirements.c b/common/requirements.c index 53522425bc..8b6f39c871 100644 --- a/common/requirements.c +++ b/common/requirements.c @@ -3409,6 +3409,8 @@ bool universal_never_there(const struct universal *source) return !utype_flag_is_in_use(source->value.unitflag); case VUT_UCFLAG: return !uclass_flag_is_in_use(source->value.unitclassflag); + case VUT_EXTRAFLAG: + return !extra_flag_is_in_use(source->value.extraflag); case VUT_OTYPE: case VUT_SPECIALIST: case VUT_AI_LEVEL: @@ -3441,7 +3443,6 @@ bool universal_never_there(const struct universal *source) case VUT_MINHP: case VUT_AGE: case VUT_ROADFLAG: - case VUT_EXTRAFLAG: case VUT_MINCALFRAG: case VUT_TERRAIN: case VUT_EXTRA: -- 2.20.1